Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media modal doesn't work on frontend using pods form #4715

Closed
JoryHogeveen opened this issue Jan 17, 2018 · 6 comments
Closed

Media modal doesn't work on frontend using pods form #4715

JoryHogeveen opened this issue Jan 17, 2018 · 6 comments
Assignees
@sc0ttkclark @pglewis
Labels
Type: Bug
Milestone
Pods 2.7.10

Comments

@JoryHogeveen
Copy link
Member

It works when using the tinyMCE field but the file field doesn't trigger a media modal.
@JoryHogeveen JoryHogeveen added this to the Pods 2.7.2 milestone Jan 17, 2018
@JoryHogeveen
Copy link
Member Author

JoryHogeveen commented Jan 17, 2018 •
edited
Loading

Might be related:

Uncaught (in promise) TypeError: Cannot read property 'getNotificationManagerImpl' of undefined
    at h (tinymce.min.js?ver=4607-20171116:28)
    at k (tinymce.min.js?ver=4607-20171116:28)
    at <anonymous>

@pglewis
Copy link
Contributor

pglewis commented Feb 6, 2018 •
edited
Loading

Disallowing the Media Library and forcing plupload when not in admin needs a rethink.

https://github.com/pods-framework/pods/blob/16d16b0/classes/fields/file.php?ts=4#L450-L453

@pglewis
Copy link
Contributor

pglewis commented Mar 16, 2018

Pinging @sc0ttkclark: I don't think unconditional rejection is the right approach; at the very least I think we need a filter to override and allow using Media Library.

@sc0ttkclark
Copy link
Member

Is this any help? https://wordpress.stackexchange.com/a/243402/296

@pglewis
Copy link
Contributor

pglewis commented Mar 16, 2018

Sorry, it's not a technical issue to display it, we're disallowing it (see code link above)

@pglewis pglewis modified the milestones: Pods 2.7.2, Pods 2.7.3, Pods 2.7.4 May 2, 2018
@pglewis pglewis modified the milestones: Pods 2.7.4, Pods 2.7.5, Pods 2.7.6 Jun 3, 2018
@jimtrue jimtrue modified the milestones: Pods 2.7.6, Pods 2.7.7 Jun 8, 2018
@pglewis pglewis modified the milestones: Pods 2.7.7, Pods 2.7.8, Pods 2.7.9 Jul 26, 2018
@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.7.9, Pods 2.7.10 Aug 9, 2018
@pglewis pglewis mentioned this issue Sep 6, 2018
Merged
@pglewis
Copy link
Contributor

pglewis commented Sep 6, 2018

PR: #5149

pglewis added a commit that referenced this issue Oct 27, 2018
@pglewis
Changelog for #4715
531475d
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sc0ttkclark sc0ttkclark

@pglewis pglewis

Labels
Type: Bug
Projects
None yet
Milestone
Pods 2.7.10
Development

No branches or pull requests
4 participants
@sc0ttkclark @JoryHogeveen @pglewis @jimtrue