Fix foreach check_value loop by checking first if it is an array #5205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Advanced search filter in Admin UI was giving (after choosing any criteria):
Warning: Invalid argument supplied for foreach() in .../wp-content/plugins/pods/classes/fields/pick.php on line 1818
Using:
Pods - Custom Content Types and Fields: 2.7.9
WordPress Version: 5.0-beta5
PHP Version: 7.2.12
Types of changes
IF check before foreach loop to test if $check_value variable is an array or not.
Changelog
Avoid PHP warnings by removing unused $check_value logic in PodsField_Pick