Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateTime/Time field enhancements #5302

Merged
merged 4 commits into from
Jun 13, 2019
Merged

DateTime/Time field enhancements #5302

merged 4 commits into from
Jun 13, 2019

Conversation

JoryHogeveen
Copy link
Member

@JoryHogeveen JoryHogeveen commented Feb 20, 2019 •
edited
Loading

Some enhancements for the Date/Time fields I've found after #5297

  • The Time field didn't reflect the changes made in Always use date_i18n to ensure proper localization. #5297.
    • Removed redundant method override in PodsField_Time (format_value_display())
  • Minor performance enhancement (do not create local DateTime instance if it isn't required)
  • Get format for display in a separate method (better for testing & class inheritance)
  • Sync code format between DateTime/Time field classes.

@JoryHogeveen JoryHogeveen added Status: Need Dev Feedback Waiting on feedback from developer of PR Status: PR > Pending Code Review PR is pending code review by core developers Type: Code Standards labels Feb 20, 2019
@JoryHogeveen JoryHogeveen added this to the Pods 2.7.13 milestone Feb 20, 2019
@JoryHogeveen JoryHogeveen self-assigned this Feb 20, 2019
@pglewis pglewis added the Status: PR > QA pending QA needs to be done label Feb 20, 2019
jimtrue
jimtrue approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@jimtrue jimtrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Test Passed (validated with a Date and Date/Time Field)

@jimtrue jimtrue added Status: PR > QA pass QA passed and removed Status: PR > QA pending QA needs to be done labels Mar 4, 2019
@JoryHogeveen JoryHogeveen removed the Status: Need Dev Feedback Waiting on feedback from developer of PR label Jun 13, 2019
@sc0ttkclark sc0ttkclark added Status: PR > Reviewed and Ready PR has been code reviewed by core developers and is ready for merge (if it passes QA) and removed Status: PR > Pending Code Review PR is pending code review by core developers labels Jun 13, 2019
@sc0ttkclark sc0ttkclark merged commit 44075b2 into 2.x Jun 13, 2019
@sc0ttkclark sc0ttkclark deleted the feature/5296-datetime-localization branch June 13, 2019 17:34
JoryHogeveen added a commit that referenced this pull request Jun 25, 2019
@JoryHogeveen
Changelog for #5302
b24ad5d
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc0ttkclark sc0ttkclark sc0ttkclark approved these changes

@jimtrue jimtrue jimtrue approved these changes

@pglewis pglewis Awaiting requested review from pglewis

Assignees

@JoryHogeveen JoryHogeveen

Labels
Status: PR > QA pass QA passed Status: PR > Reviewed and Ready PR has been code reviewed by core developers and is ready for merge (if it passes QA) Type: Code Standards
Projects
None yet
Milestone
Pods 2.7.13
Development

Successfully merging this pull request may close these issues.
4 participants
@JoryHogeveen @sc0ttkclark @jimtrue @pglewis