Skip to content

Commit

Permalink
fix(jpa): make advanced JDBC options not log warnings IQSS#7980
Browse files Browse the repository at this point in the history
With the addition of the advanced (but proprietary, Payara-only) settings
for database connection monitoring, the non-present default for connection
validation triggered unnecessary log clutter. Adding an empty default
makes these go away and is inline with the default of Payara.
  • Loading branch information
poikilotherm committed Aug 11, 2022
1 parent 8a1ee7e commit e81b20c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions doc/sphinx-guides/source/installation/config.rst
Original file line number Diff line number Diff line change
Expand Up @@ -327,13 +327,13 @@ Connection Validation
* - dataverse.db.connection-validation-method
- | The method of connection validation:
| ``table|autocommit|meta-data|custom-validation``
- *No default*
- *Empty string*
* - dataverse.db.validation-table-name
- The name of the table used for validation if the validation method is set to ``table``
- *No default*
- *Empty string*
* - dataverse.db.validation-classname
- The name of the custom class used for validation if the ``validation-method`` is set to ``custom-validation``
- *No default*
- *Empty string*
* - dataverse.db.validate-atmost-once-period-in-seconds
- Specifies the time interval in seconds between successive requests to validate a connection at most once.
- ``0`` (disabled)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@
// https://docs.payara.fish/community/docs/documentation/payara-server/jdbc/advanced-connection-pool-properties.html
// VALIDATION
"fish.payara.is-connection-validation-required=${MPCONFIG=dataverse.db.is-connection-validation-required:false}",
"fish.payara.connection-validation-method=${MPCONFIG=dataverse.db.connection-validation-method}",
"fish.payara.validation-table-name=${MPCONFIG=dataverse.db.validation-table-name}",
"fish.payara.validation-classname=${MPCONFIG=dataverse.db.validation-classname}",
"fish.payara.connection-validation-method=${MPCONFIG=dataverse.db.connection-validation-method:}",
"fish.payara.validation-table-name=${MPCONFIG=dataverse.db.validation-table-name:}",
"fish.payara.validation-classname=${MPCONFIG=dataverse.db.validation-classname:}",
"fish.payara.validate-atmost-once-period-in-seconds=${MPCONFIG=dataverse.db.validate-atmost-once-period-in-seconds:0}",
// LEAK DETECTION
"fish.payara.connection-leak-timeout-in-seconds=${MPCONFIG=dataverse.db.connection-leak-timeout-in-seconds:0}",
Expand Down

0 comments on commit e81b20c

Please sign in to comment.