Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes definition of point of interest and limits the number of POIs #93

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

abelsiqueira
Copy link
Contributor

Description

The definition was changed to ignore the max_distance.
A maximum number of POIs per label is selected now.

Related issues:

Closes #91

Instructions to review the pull request

The CI tests are enough

Copy link
Contributor

@lyashevska lyashevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@abelsiqueira abelsiqueira merged commit fe55655 into main Jun 19, 2023
@abelsiqueira abelsiqueira deleted the 91-max-poi-per-label branch June 19, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change POI definition and limit maximum POI per label
2 participants