Update to 26 and allow on all pages #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason the height is not correct anymore when removing the header. This fixes it. Before: https://transfer.cosmos-ink.net/olqgYSN9uy/screenshot6782.png After: https://transfer.cosmos-ink.net/EVGn5IjYiO/screenshot6783.png
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
when adding Nextcloud News to Ferdium, I found the top bar annoying and found your great extension to remedy it.
Being on 26 it didn't work as expected and I also later learned it was meant to only work with the files page/app.
This updates the app to work version 26 and removes the limitation of only working on the files app.
One issue that came up when fixing the top menu bar was that the lowest button in the sidebar (usually settings) kept clipping out of the content area. I fixed that as well and it seems to work well everywhere.
Tested it on most default apps and some third party ones and it seems all well.
I have never worked with nextcloud apps from the development side, so feel free to point out issues or simply if you don't wish some change. (E.g. maybe add a disclaimer telling that anything other than files might not be tested to work officially.)