Fix state sharing bug in .dependency(_:_:)
trait
#309
+46
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
.dependency(_:_:)
function is used with a reference type to override the dependency for a test suite, tests can inadvertently share state because the same instance is used for each test:To fix this, this PR changes the
value
argument to be an@autoclosure
so that a new instance can be created for each test. Let me know if there's an alternate solution that would be better!