Use Static Functions #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
Feb 9, 2019
| let doc: Node = .document( | ||
| .html( | ||
| .head( | ||
| .style(safe: stylesheet) |
There was a problem hiding this comment.
One weird concession was without making safe vs. unsafe explicit, I'd get ambiguous errors that required as StaticString even on string literals. Was strange and maybe worth filing a bug for!
stephencelis
commented
Feb 9, 2019
| img(base64: "ZnVuY3Rpb25z", type: .image(.svg), alt: "", [Html.class("hide-d")]) | ||
| .body( | ||
| .header( | ||
| attributes: [.class("bg-purple150 d-pt4 d-pb4 m-pl2 m-pr2 m-pt2 m-pb2")], |
There was a problem hiding this comment.
.class is feelin nicer than Html.class or backticks!
mbrandonw
reviewed
Feb 9, 2019
| @@ -1,136 +1,79 @@ | |||
| <a> | |||
| foo1 | |||
There was a problem hiding this comment.
are all the deletions in this file intended?
There was a problem hiding this comment.
I think so but will audit. We were testing each overload before.
|
Gonna merge for now! Can make future adjustments before any official release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a preliminary PR for what we talked about!
Right now I use
attributes: […]consistently everywhere, but functions with no content could use_ attributes: Attribute...instead.We could also add overloads to accept
.asyncwherever booleans like.async(true)work.