-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift 4 #54
Swift 4 #54
Conversation
@@ -1,4 +1,4 @@ | |||
// swift-tools-version:5.0 | |||
// swift-tools-version:4.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tools version should (almost) always be the minimum supported version. We could alternately maintain a separate manifest as described here: https://github.com/apple/swift-package-manager/blob/master/Documentation/Usage.md#version-specific-manifest-selection
But I was discouraged from doing so.
Once merged this should fix #53. |
(Build's broken because SnapshotTesting dropped Swift 4 support. I'll add it back.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Chatted with the fine folks on the SPM Slack and looks like this is the way to go about supporting Swift 4 and 5 at the same time.