Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression: don't fatalError eagerly when calling deprecated unimplemented endpoints #114

Conversation

grigorye
Copy link
Contributor

@grigorye grigorye commented Aug 14, 2024

Fixes #113.

@stephencelis stephencelis changed the title Illustration for https://github.com/pointfreeco/swift-issue-reporting/issues/113 Fix regression: don't fatalError eagerly when calling deprecated unimplemented endpoints Aug 14, 2024
Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test case!

@stephencelis stephencelis merged commit a4c2b6d into pointfreeco:main Aug 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unimplemented() without placeholder for @MainActor closures crashes _on generation_ (regression vs 1.1.2)
2 participants