Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capitals and stuff #60

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Capitals and stuff #60

wants to merge 4 commits into from

Conversation

DraKay
Copy link
Contributor

@DraKay DraKay commented Jan 20, 2023

Each commit of this pr is commented explaining why I make each thing... Please anyone changing after this could link what ortographic rule is folliwing and talk in discord first about changes of words that were already agreed? Thanks

@DraKay
Update pokemon.json
511b918 
Both words Rose and Pink are translated both as Rosa in Spanish. And as pink is the widest meaning of them, making it the first one that come to mind when you read that word is better and more understable to use FLOR word that even having a less precise meaning than Rosa is less confusing about the meaning and other uses of the word.
@DraKay
Update pokemon.json
d72e71d 
Use Rosa as a direct translate of pinkan and to avoid the use of Rosada word that have a strong relationship with wine  and other secondary meanings not intended here.


This translation was talk and decided commonly in wiki translate channel of discord within French and Spanish translators.
@DraKay
Update pokemon.json
b58f8c6 
Use anime way of call ash greninja as game one (shorter because space) is grammatically incorrect
@DraKay
Update pokemon.json
283dfb0 
To avoid problems a extrict use of RAE rules of capitalization si gonna be used to use them so only will appear capitals letters in the following cases:

3.1 When it is the first word of the name
4.1 When is a Pokémon name as it is considered as person name
4.7 Geographical names
4.13 Cardinal Points
https://www.rae.es/dpd/may%C3%BAsculas

I have my doubts regarding rule 4.11 as it isn't an astronomical text but SM and UsUm are very based in astronomy... For now I will treat it as not astronomical text but if someone differ feel free to speak it in discord
@osherwott
Copy link
Contributor

osherwott commented Jan 21, 2023 •
edited
Loading

Finally got around to reading this! Thanks for being patient Drak! Here's my feedback, so we can finally get this sorted out:

  • "rosa" is fine for Pinkan, I agree!
  • Rose and Pink are indeed a conundrum. Since lowercase pink "rosa" is grammatically correct, maybe we could keep "Rosa" as rose? If that's too confusing, maybe "Flor de Rosa"? If it were up to me I'd keep it as "Flor", but certain other Spanish speakers might want otherwise...
  • There is actually no character limit on alternate forms, since they do not appear in the pokemon's name during battle (otherwise our job would be much easier!). "Greninja Ash" is technically more correct (the notification when the ability activates in the games spells it like that) even if it sadly doesn't look right :(
  • I trust you to know the full extent of RAE rules! Any decisions made based on that gets a pass from me! 👍

Things to note:

  • Some of your changes here contradict your other translations. I think it'd be best to check that you aren't making any changes here that would be overwritten by your Magikarp one. For example, you have "Shaymin (Tierra)" there, so if you're not careful it might replace your fixed "Shaymin (tierra)" here!
  • This might be intentional, but you have also corrected your own mistakes, such as "Crema de vainilla" into "crema de vainilla", and other first words in parentheses, like "Forma", all the Pumpkaboo sizes, and "Flor" for Flabébé colors. I don't want to imply that you're wrong! I just want you to be aware of this because you might mistakenly replace your own corrections if you don't pay attention, and I want to make sure you know that there is no rush :) Everything will be fixed!
  • Similar to the above bullet point, you also changed your own capitalization for Solgaleo and Lunala's forms. I only bring this up separately because you mentioned that Sol and Luna are astronomical terms and I think your first translations were fine as they were, because they are supposed to refer to the real the Sun and Moon
  • Since you are making most forms lowercase, I would also go and check on any pokemon whose names are taken from the English file, like Vivillon or Furfrou. Otherwise you will have (Continental) and (Kabuki) instead of (continental) and (kabuki)!
  • You have spelling mistakes on Lines 1114 and 1195. (Don't stress Drak!)

I can take a better look at the rest of the file if you want, I'm always happy to help! These are just what I noticed at first glance. Don't hesitate to talk to me if you need anything! We're all a team now and you don't have to feel like you're doing this alone!

EDIT

It seems Solgaleo and Lunala's phases should be capitalized
formas de sol y luna

https://web.archive.org/web/20170704101658/http://www.pokemon-sunmoon.com:80/es-es/pokemon
(you need to open the console to get rid of the loading screen, but this is the site)

Same with Necrozma's forms
image
image

https://web.archive.org/web/20171021235633/http://www.pokemon-sunmoon.com/ultra/es-es/gallery.html

@Aegyo
Copy link
Contributor

Aegyo commented Jan 7, 2024

@DraKay any response to osherwott on this one? It also has a lot of conflicts now so if you want this it may be better to do a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DraKay @osherwott @Aegyo