Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Consensus] State Sync - Server to Advertise Blocks #409

Closed
8 tasks
jessicadaugherty opened this issue Dec 19, 2022 · 0 comments · Fixed by #431
Closed
8 tasks

[Consensus] State Sync - Server to Advertise Blocks #409

jessicadaugherty opened this issue Dec 19, 2022 · 0 comments · Fixed by #431
Assignees
@gokutheengineer
Labels
consensus Consensus specific changes
Milestone
M1: Pocket PoS (P...

Comments

@jessicadaugherty
Copy link
Contributor

jessicadaugherty commented Dec 19, 2022 •
edited
Loading

Objective

To sync to the blockchain, nodes need to be able to retrieve blocks from peers. These blocks must be advertised to peers to be validated and applied in chronological order against state data before participating in the network. In order to begin syncing, a sync server should be implemented to advertise blocks from peers for other peers to request.

Origin Document

V0 Client Side Challenge Mechanism

Goals

  • Build a sync server that advertises blocks from peers

Deliverable

  • Sync server that advertises its blocks and height for full sync (block 1)
  • Sync server that also provides requested blocks and height to peers

Non-goals / Non-deliverables

  • Implementation of block requests by the client
  • Implementation of block retrieval by the client

General issue deliverables

  • Update the appropriate CHANGELOG(s)
  • Update any relevant local/global README(s)
  • Update relevant source code tree explanations
  • Add or update any relevant or supporting mermaid diagrams

Testing Methodology

  • All tests: make test_all
  • LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @jessicadaugherty
@jessicadaugherty jessicadaugherty converted this from a draft issue Dec 19, 2022
@jessicadaugherty jessicadaugherty added the consensus Consensus specific changes label Dec 19, 2022
@jessicadaugherty jessicadaugherty changed the title [Consensus] State Sync - Create Server to Advertise Blocks [Consensus] State Sync - Server to Advertise Blocks Dec 19, 2022
@Olshansk Olshansk mentioned this issue Dec 21, 2022
Merged
16 tasks
@gokutheengineer gokutheengineer moved this from Up Next to In Progress in V1 Dashboard Jan 6, 2023
This was referenced Jan 6, 2023
Merged
Merged
@gokutheengineer gokutheengineer moved this from In Progress to In Review in V1 Dashboard Jan 29, 2023
gokutheengineer added a commit that referenced this issue Feb 9, 2023
@gokutheengineer @Olshansk
[Consensus] State sync server to advertise blocks (#431)
e32df6b 
## Description

This PR aims to implement state sync server module.

## Issue

Fixes #409 

## Type of change

Please mark the relevant option(s):

- [X] New feature, functionality or library
- [ ] Bug fix
- [X] Code health or cleanup
- [ ] Major breaking change
- [ ] Documentation
- [ ] Other <!-- add details here if it a different type of change -->

## List of changes

<!-- REMOVE this comment block after following the instructions
 List out all the changes made
-->

-  Add `state_sync` submodule to Consensus Module
- Implement state sync server to advertise blocks and metadata
- Create new `state_snyc_handler.go` source file that handles
stateSyncMessages sent to the consensus module
- Write state sync server tests, update hotstuff test 
-  Add `ConsensusStateSync` interface to the shared module


## Testing

- [X] `make develop_test`
- [X]
[LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md)
w/ all of the steps outlined in the `README`

<!-- REMOVE this comment block after following the instructions
 If you added additional tests or infrastructure, describe it here.
 Bonus points for images and videos or gifs.
-->

## Required Checklist

- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [X] I have tested my changes using the available tooling
- [X] I have updated the corresponding CHANGELOG

### If Applicable Checklist
- [ ] I have updated the corresponding README(s); local and/or global
- [X] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have added, or updated,
[mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding
README(s)
- [ ] I have added, or updated, documentation and
[mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*`
if I updated `shared/*`README(s)

---------

Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>
@github-project-automation github-project-automation bot moved this from In Review to Done in V1 Dashboard Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gokutheengineer gokutheengineer

Labels
consensus Consensus specific changes
Projects
V1 Dashboard
Status: Done
Milestone
M1: Pocket PoS (Proof of Stake)
Development

Successfully merging a pull request may close this issue.

[Consensus] State sync server to advertise blocks pokt-network/pocket
2 participants
@jessicadaugherty @gokutheengineer