-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tooling] Create build makefile #390
Conversation
Currently working in #366 (comment) |
@Gustavobelfort For future reference, please make sure to update all the "logistical" things:
E.g. the "list of changes" is actually the list of issues that should be in the Will let you give you a shot and lmk if you have any questions after updating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gustavobelfort Looking really good so far! Took a first round of review with some comments and questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gustavobelfort Looking really good so far! Took a first round of review with some comments and questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the PR description!
Also, any reason to keep this as a draft?
@Gustavobelfort Let me know when this is ready for another look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you @Gustavobelfort! 🙌
What we usually do is "Squash & Merge" + Put the PR description as the body of the commit. Go for it :)
Description
This pr is responsible for both implementing targets to build the pocket binaries defined in the
app/
folder and for refactoring the help targets/comments used in the root makefile into cleaner and more readable commands.The build targets also take in consideration the naming requirements for the binaries and allow them to be changed easily without having to change any package names.
Issue
Fixes #366
Type of change
Please mark the relevant option(s):
List of changes
Testing
make develop_test
README
Required Checklist
If Applicable Checklist
shared/docs/*
if I updatedshared/*
README(s)