[Persistence] Add logic for updateParamsTree and updateFlagsTree functions for the Sparse Merkle Tree

[h5law]

Description

This PR is in response to the comments left in the peristence/state.go file:

The functions work by utilising the new getParamsUpdated(height int64) and getFlagsUpdated(height int64) functions that return a slice of []*coreTypes.Param and []*coreTypes.Flag respectively. The function runs a query against the PostgreSQL DB to get all the parameter's/flag's at the given height, their names, values, and heights (+enabled status for flags) are then loaded from the returned rows into individual Param or Flag protobufs and these are then returned.

The updateParamsTree and updateFlagsTree functions then iterate over each protobuf in this slice and for each one runs the SMT Update function using the result of crypto.SHA3Hash([]byte(proto.String())) function (where proto is either param or flag depending on the function) as the key, and the marshalled protobuf as a []byte as the value.

The corresponding hashes have been updated in the TestStateHash_DeterministicStateWhenUpdatingAppStake test, following the comment at the start of the function.

Issue

Fixes N/A

Type of change

Please mark the relevant option(s):

• New feature, functionality or library
• Bug fix
• Code health or cleanup
• Major breaking change
• Documentation
• Other

List of changes

• Create Param and Flag protobufs
• Create the getParamsOrFlagsAtHeightQuery() and getParamsUpdated() and getFlagsUpdated() functions to return the a slice of the respective protobufs for the given height
• Define the logic in the updateParamsTree() and updateFlagsTree() functions to utilise these functions and update their respective Merkle Trees
• Update the TestStateHash_DeterministicStateWhenUpdatingAppStake test hardcoded hashes to use new ones as the business logic has changed for calculating these
• Replace all uses of proto.Marshal with codec.GetCodec().Marshal() in persistence/state.go

Testing

• make develop_test
• LocalNet w/ all of the steps outlined in the README

Required Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have tested my changes using the available tooling
• I have updated the corresponding CHANGELOG

If Applicable Checklist

• I have updated the corresponding README(s); local and/or global
• I have added tests that prove my fix is effective or that my feature works
• I have added, or updated, mermaid.js diagrams in the corresponding README(s)
• I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

[h5law]

Something I was concerned about is whether the ParamOrFlag struct definition is in an appropriate file? I thought peristence/types/gov.go as this is where other Parameter/Flag stuff is located.

Also whether the method for generating the keys/values to actually update the trees is alright? I chose this method as the other functions have types already so defining the struct and its Hash() and GetBytes() method seemed to follow a good pattern at least, but the value string I am using (before converting to []byte) was really out of nowhere due to this type being explicitly made for this purpose.

[Olshansk]

Definitely heading in the right direction and most of the logic is in place. Left a couple of major regarding next steps.

Let me know if you need any more clarifying details

[Olshansk]

Almost good to go!

[Olshansk]

Do you mind replacing the other proto.Marshal to codec.GetCodec().Marhsal()?

After that, feel free to merge!