-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][IBC] Create the initial IBC module #795
Conversation
@bryanchriswhite I've added you to this PR instead of @dylanlott since I know you've been putting a lof thought into how we should structure/design our module interfaces. @dylanlott feel free to take a look as well but where I believe your input would be most valuable is around how IBC interfaces with the persistence layer. |
@h5law I've removed the |
I have split this PR into the following #842 which introduces the initial module creation as well as #838 which introduces the changes made to the KVStore. I have also opened the following issues #841 #840 which cover the rest of the implementation detailed in this PR. As such I am closing this PR as the work will be done in follow up issues. |
Description
This PR implements ICS23 and ICS24 (in part) specifically the paths, and stores.
The IBC module requires numerous data types and interfaces to be defined and as such the
IBCHost
interface defined in ICS25 has been written but commented out all of its methods.This initial module contains the
StoreManager
, with both private and provable stores. As well as the numerousCommitment
objects for proofs and path usage.Issue
Fixes #794
Type of change
Please mark the relevant option(s):
List of changes
Testing
make develop_test
; if any code changes were mademake test_e2e
on k8s LocalNet; if any code changes were madee2e-devnet-test
passes tests on DevNet; if any code was changedRequired Checklist
godoc
format comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*
if I updatedshared/*
README(s)