-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [Persistence] TreeStore Module Tests #836
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanlott
changed the title
TreeStore Module Tests
[WIP] [Persistence] TreeStore Module Tests
Jun 16, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## tree-store-module #836 +/- ##
=====================================================
+ Coverage 30.80% 31.87% +1.06%
=====================================================
Files 109 109
Lines 9245 9253 +8
=====================================================
+ Hits 2848 2949 +101
+ Misses 6057 5932 -125
- Partials 340 372 +32
☔ View full report in Codecov by Sentry. |
18 tasks
dylanlott
force-pushed
the
tree-store-module
branch
from
June 21, 2023 00:36
ed85d71
to
3d64a86
Compare
dylanlott
force-pushed
the
tree-store-tests
branch
from
June 21, 2023 03:16
9a88f1b
to
eff08e7
Compare
dylanlott
force-pushed
the
tree-store-module
branch
from
June 21, 2023 17:27
52e18e3
to
758798e
Compare
dylanlott
force-pushed
the
tree-store-tests
branch
from
June 21, 2023 23:37
eff08e7
to
1f8c001
Compare
dylanlott
force-pushed
the
tree-store-tests
branch
from
June 21, 2023 23:39
1f8c001
to
425717d
Compare
dylanlott
force-pushed
the
tree-store-module
branch
2 times, most recently
from
June 22, 2023 16:24
07068f4
to
5b2f60b
Compare
Superseded by #861 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tests for the TreeStore module
Summary generated by Reviewpad on 21 Jun 23 23:39 UTC
This pull request includes changes that affect multiple packages in the
persistence
module.transaction.go
has been added to the package that defines aCoordinator
struct and aTx
struct.indexer
package include the addition of atomic transaction methods to theTxIndexer
interface.treeStore
struct and its methods include the addition of a new field and renaming of a method.In addition, changes have been made to individual files that add new methods, implement unit tests, and remove unused variables.
Issue
Relates to #756
Type of change
Please mark the relevant option(s):
List of changes
Testing
make develop_test
; if any code changes were mademake test_e2e
on k8s LocalNet; if any code changes were madee2e-devnet-test
passes tests on DevNet; if any code was changedRequired Checklist
godoc
format comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*
if I updatedshared/*
README(s)