Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Persistence] TreeStore Module Tests #836

Closed
wants to merge 58 commits into from

Conversation

dylanlott
Copy link
Contributor

@dylanlott dylanlott commented Jun 16, 2023

Description

Adds tests for the TreeStore module

Summary generated by Reviewpad on 21 Jun 23 23:39 UTC

This pull request includes changes that affect multiple packages in the persistence module.

  • A new file named transaction.go has been added to the package that defines a Coordinator struct and a Tx struct.
  • Changes to the existing indexer package include the addition of atomic transaction methods to the TxIndexer interface.
  • Changes to the treeStore struct and its methods include the addition of a new field and renaming of a method.

In addition, changes have been made to individual files that add new methods, implement unit tests, and remove unused variables.

Issue

Relates to #756

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Adds a WithTxIndexer option function for configuring the tree module
  • Adds a test for creating a TreeStoreModule
  • Adds tests for the Update function
  • Lays the ground work for further detailed state hash tests

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@reviewpad reviewpad bot added the large Pull request is large label Jun 16, 2023
@dylanlott dylanlott changed the title TreeStore Module Tests [WIP] [Persistence] TreeStore Module Tests Jun 16, 2023
@dylanlott dylanlott changed the base branch from main to tree-store-module June 16, 2023 22:54
@dylanlott dylanlott self-assigned this Jun 16, 2023
@dylanlott dylanlott added the persistence Persistence specific changes label Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage: 70.00% and project coverage change: +1.06 🎉

Comparison is base (113e3be) 30.80% compared to head (9a88f1b) 31.87%.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           tree-store-module     #836      +/-   ##
=====================================================
+ Coverage              30.80%   31.87%   +1.06%     
=====================================================
  Files                    109      109              
  Lines                   9245     9253       +8     
=====================================================
+ Hits                    2848     2949     +101     
+ Misses                  6057     5932     -125     
- Partials                 340      372      +32     
Impacted Files Coverage Δ
persistence/trees/module.go 68.51% <66.66%> (+68.51%) ⬆️
persistence/trees/trees.go 38.78% <100.00%> (+38.78%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dylanlott dylanlott force-pushed the tree-store-module branch 2 times, most recently from 07068f4 to 5b2f60b Compare June 22, 2023 16:24
@dylanlott dylanlott closed this Jun 29, 2023
@dylanlott
Copy link
Contributor Author

Superseded by #861

@dylanlott dylanlott deleted the tree-store-tests branch June 29, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large persistence Persistence specific changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants