-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IBC] Add Event Logging system #893
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olshansk
reviewed
Jul 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments & nits here and there but overall, this is 🧹 and 💅
Olshansk
requested changes
Jul 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments & nits here and there but overall, this is 🧹 and 💅
Olshansk
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
e2e-devnet-test
Runs E2E tests on devnet
ibc
IBC specific changes
large
Pull request is large
waiting-for-review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 13 Jul 23 12:29 UTC
This pull request introduces several changes across multiple files. Here is a summary of the diff:
benchmark_state_test.go
, a slice ofuint8
is modified to generate a random value using therand.Intn
function, preventing duplicate keys.persistence_module.go
, new methodsSetIBCEvent
andGetIBCEvents
are added to enhance the persistence module's functionality for handling IBC events.SetIBCEvent
andGetIBCEvents
are added for storing and retrieving IBC events at a specific height and topic.persistence/types/ibc.go
, multiple changes include adding constants, new functions for generating queries, renaming a function, and modifying existing functions for handling IBC events and entries.bus.go
, a new functionGetEventLogger
is added to thebus
struct, returning a value of typemodules.EventLogger
.Create()
function in theibc/host
package.ibc_test.go
, there are modifications to test functions, adding new test functions, and adding anattribute
struct.ibc_event_module.go
is added, defining a package, imports, constants, types, and methods related to an event logging system.bus_module.go
show the addition of a new methodGetEventLogger
to theBus
interface.persistence/debug.go
, functionsClearAllIBCQuery
,ClearAllIBCStoreQuery
, andClearAllIBCEventsQuery
are added/removed, and a modification is made to theHandleDebugMessage
function signature.event_manager.go
is added, containing the definition of theEventManager
struct and implementing theEventLogger
interface.ics24.md
introduce a new section for an event logging system in the IBC module, with an overview of its implementation and usage of a persistence layer.ibc_events.proto
is added, defining message types for attributes and IBC events in the shared/core/types/proto directory.These changes aim to introduce and enhance functionality related to IBC events, event logging, and persistence in the project.
Issue
Fixes #824
Type of change
Please mark the relevant option(s):
List of changes
EventLogger
interface and submoduleIBCEvent
protobuf typeEventLogger
to the bus for retrievalTesting
make develop_test
; if any code changes were mademake test_e2e
on k8s LocalNet; if any code changes were madee2e-devnet-test
passes tests on DevNet; if any code was changedRequired Checklist
godoc
format comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*
if I updatedshared/*
README(s)