feat: gc binview when writing ipc

pola-rs · Jan 27, 2024 · 0bc9eaf · 0bc9eaf
1 parent c088edb
commit 0bc9eaf
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/crates/polars-arrow/src/array/binview/mod.rs b/crates/polars-arrow/src/array/binview/mod.rs
@@ -373,6 +373,10 @@ impl<T: ViewType + ?Sized> BinaryViewArrayGeneric<T> {
         mutable.freeze().with_validity(self.validity)
     }
 
+    pub fn is_sliced(&self) -> bool {
+        self.views.as_ptr() != self.views.storage_ptr()
+    }
+
     pub fn maybe_gc(self) -> Self {
         const GC_MINIMUM_SAVINGS: usize = 16 * 1024; // At least 16 KiB.
 

diff --git a/crates/polars-arrow/src/io/ipc/write/serialize/binview.rs b/crates/polars-arrow/src/io/ipc/write/serialize/binview.rs
@@ -10,9 +10,14 @@ pub(super) fn write_binview<T: ViewType + ?Sized>(
     is_little_endian: bool,
     compression: Option<Compression>,
 ) {
+    let array = if array.is_sliced() {
+        array.clone().maybe_gc()
+    } else {
+        array.clone()
+    };
     write_bitmap(
         array.validity(),
-        array::Array::len(array),
+        array::Array::len(&array),
         buffers,
         arrow_data,
         offset,