Skip to content

Commit

Permalink
Update link to related issue
Browse files Browse the repository at this point in the history
  • Loading branch information
stinodego committed Jul 15, 2024
1 parent 063a7c7 commit 353559d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion crates/polars-lazy/src/scan/csv.rs
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,8 @@ impl LazyCsvReader {
where
F: Fn(Schema) -> PolarsResult<Schema>,
{
// TODO: This should be done when converting to the IR
// TODO: Path expansion should happen when converting to the IR
// https://github.com/pola-rs/polars/issues/17634
let paths = expand_paths(self.paths(), self.glob(), self.cloud_options())?;

let Some(path) = paths.first() else {
Expand Down
2 changes: 1 addition & 1 deletion py-polars/tests/unit/io/test_lazy_csv.py
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ def test_file_list_comment_skip_rows_16327(tmp_path: Path, streaming: bool) -> N
assert_frame_equal(out, expect)


@pytest.mark.xfail(reason="Bug: https://github.com/pola-rs/polars/issues/17444")
@pytest.mark.xfail(reason="Bug: https://github.com/pola-rs/polars/issues/17634")
def test_scan_csv_with_column_names_nonexistent_file() -> None:
path_str = "my-nonexistent-data.csv"
path = Path(path_str)
Expand Down

0 comments on commit 353559d

Please sign in to comment.