fix(python): Raise ValueError on adding float to Series of dtype date (…

…#6677)
pola-rs · Feb 5, 2023 · 96490f2 · 96490f2
1 parent b77265b
commit 96490f2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/py-polars/polars/datatypes.py b/py-polars/polars/datatypes.py
@@ -801,5 +801,10 @@ def maybe_cast(
 
     py_type = dtype_to_py_type(dtype)
     if not isinstance(el, py_type):
-        el = py_type(el)  # type: ignore[call-arg]
+        try:
+            el = py_type(el)  # type: ignore[call-arg]
+        except Exception:
+            raise ValueError(
+                f"Cannot convert Python type {type(el)} to {dtype}"
+            ) from None
     return el
diff --git a/py-polars/tests/unit/test_series.py b/py-polars/tests/unit/test_series.py
@@ -340,7 +340,7 @@ def test_arithmetic(s: pl.Series) -> None:
         2 % a
     with pytest.raises(ValueError):
         2**a
-    with pytest.raises(TypeError):  # https://github.com/pola-rs/polars/issues/6617
+    with pytest.raises(ValueError):
         +a
     a = pl.Series("a", [""])
     with pytest.raises(ValueError):