-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing docstring examples #13161
Comments
Please refer to our contributing guide for guidance on writing good doc examples: |
@stinodego Was thinking I should break the missing examples into more manageable chunks with an issue each, what do you think? |
I don't think that's necessary. If people want to contribute docstring examples, this issue is sufficient to find out where the gaps are. |
Should the file be called needs_examples instead of has_examples? I noticed there's a lot of Series methods on there that probably have Expr methods. Is there an automated way to put a link on the Series method to the Expr method for near examples? Also the list has a lot of deprecated methods that shouldn't have examples. The pages that are deprecated have a div class="deprecated" to make automated filtering easier. |
This looks like a fun one to familiarise myself again with the contribution process. I'll have a look at the csv file and update here if when I started working on a batch |
I would like to work on this, starting with the datetime functions. Examples are not desired for deprecated functions, correct? I will skip these to start, but can always add them later. Also, it looks like many of these functions now have examples. I can update the list. |
great to see the community effort! I'd suggest skipping anything deprecated |
I updated the list of missing examples below. |
Another update to the list |
How can I contribute? Just downloading the csv, checking what the fucntions pending do, and creating docstrings into the functions? First timmer here. |
@jmgonzalezro Have a look at the remaining docstrings that are missing an example. I just shared an updated overview. Pick the ones you want to work on and have fun. The contribution guide can help you set up your environment and create a PR: https://docs.pola.rs/development/contributing/ |
Addition to pola-rs#13545, part of pola-rs#13161
Addition to pola-rs#13545 with unnecessary doctest skips removed. Part of pola-rs#13161.
Addition to pola-rs#13545 with unnecessary doctest skips removed. Part of pola-rs#13161.
Addition to pola-rs#13545 with unnecessary doctest skips removed. Part of pola-rs#13161.
Created a PR to improve formatting for |
Hey, can I take this up? I would like to add doc examples to the following: https://pola-rs.github.io/polars/py-polars/html/reference/series/api/polars.Series.explode.html I am confused for the below function, how to write a short and good example, any help here is much appreciated. Removed entries which already has doc examples, and the above changes. |
Hey, I've created a PR for: |
Added a few more examples in this PR. I removed these from the csv and also cleaned entries already resolved. |
I'm going to close this one as we're pretty much fully covered at this point. There are a few entries left over where it's not exactly clear how to best give examples, e.g. DataType classes or I/O functionality. We can look at those separately. Thanks to everyone who has contributed! |
Description
Some of the methods lack any API examples. The attached CSV shows a list of function urls that do not currently have examples: has_examples.csv
This is a really good first issue. Some of these methods - such as the I/O methods - are more advanced but there are plenty of simpler expression and series methods there are good for new contributors. If anyone wants to have a go please reply to this issue saying which group of methods you are working on. It is best to do small PRs with just a few methods at a time.
If anyone is having trouble with the contribution process @ me here (or on discord which I see more easily)
Link
No response
The text was updated successfully, but these errors were encountered: