Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispersion measures in the arr namespace not externally available #14355

Closed
2 tasks done
etiennebacher opened this issue Feb 8, 2024 · 3 comments
Closed
2 tasks done
Labels
bug Something isn't working needs triage Awaiting prioritization by a maintainer rust Related to Rust Polars

Comments

@etiennebacher
Copy link

Checks

  • I have checked that this issue has not already been reported.
  • I have confirmed this bug exists on the latest version of Polars.

Reproducible example

/

Log output

/

Issue description

This might be a documentation issue, I'm not sure.

std, var and median functions for the arr namespace were added in #13245, but they do not appear in the list of implementations: https://docs.rs/polars/latest/polars/prelude/struct.ArrayNameSpace.html#implementations

Am I missing something?

For context, I noticed this when adding the arr namespace in r-polars. Other functions (max, sum, unique, etc.) are found but I get the error "no method named std found for struct polars::prelude::ArrayNameSpace in the current scope". Note that I use rust-polars 0.37.0, not the dev version, but those measures were implemented before the 0.37.0 release.

Expected behavior

/

Installed versions

/

@etiennebacher etiennebacher added bug Something isn't working needs triage Awaiting prioritization by a maintainer rust Related to Rust Polars labels Feb 8, 2024
@ritchie46
Copy link
Member

ritchie46 commented Feb 8, 2024

They are available on the Lazy API. Dispatch to those expressions in done via the engine.

@etiennebacher
Copy link
Author

etiennebacher commented Feb 8, 2024

I think the issue is that those functions were not yet added in the Array namespace for the version of rust-polars that I use. This is weird because I use the commit tagged in rs-0.37.0, which includes the PR "list & array measures of dispersion"

However, if I navigate the repo at the commit tagged in rs-0.37.0, we can see that those changes are not included: https://github.com/pola-rs/polars/blob/rs-0.37.0/py-polars/src/expr/array.rs

@etiennebacher
Copy link
Author

I suppose there's not much to do here, I can wait for 0.38.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Awaiting prioritization by a maintainer rust Related to Rust Polars
Projects
None yet
Development

No branches or pull requests

2 participants