Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: list & array measures of dispersion #13245

Merged
merged 18 commits into from
Jan 28, 2024

Conversation

ion-elgreco
Copy link
Contributor

@ion-elgreco ion-elgreco commented Dec 25, 2023

Summary:

  • Adds measures to arr and list namespace on Expr and Series
  • Adds support for pl.Duration inner dtypes (for var, cast first to ms to prevent overflow)
  • Adds tests

@stinodego I saw that there we some fast paths for other methods like sum where if the series doesn't contain nulls the values are collected from a slice and then summed. Should I do something similar for std, var and median here?

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Dec 25, 2023
@ion-elgreco ion-elgreco changed the title feat: list & array measures of dispersons feat: list & array measures of dispersion Dec 25, 2023
@ion-elgreco
Copy link
Contributor Author

@reswqa could you perhaps review this PR?

Copy link
Collaborator

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. This change overall looks good. I left a few comments. Also cc @ritchie46 for reviewing.

@ion-elgreco
Copy link
Contributor Author

Is there something else required to get this merged? :)

@reswqa
Copy link
Collaborator

reswqa commented Jan 11, 2024

Is there something else required to get this merged? :)

No, but we need to wait for Ritchie to make the final review.

@ion-elgreco
Copy link
Contributor Author

@reswqa ah okay!

@ritchie46
Copy link
Member

Thank you @ion-elgreco. Can you rebase? Then we can merge.

@ion-elgreco
Copy link
Contributor Author

@ritchie46 Done : )

@ritchie46 ritchie46 merged commit 775152f into pola-rs:main Jan 28, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add statistical methods to the List namespace (median, std, var)
3 participants