Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial PyO3 0.21 migration, with gil-refs feature enabled #15621

Closed
Tracked by #15215
itamarst opened this issue Apr 12, 2024 · 1 comment · Fixed by #15622
Closed
Tracked by #15215

Initial PyO3 0.21 migration, with gil-refs feature enabled #15621

itamarst opened this issue Apr 12, 2024 · 1 comment · Fixed by #15622
Labels
enhancement New feature or an improvement of an existing feature

Comments

@itamarst
Copy link
Contributor

Description

Just enough migration to upgrade, without doing the new Bound<> API yet.
@itamarst itamarst added the enhancement New feature or an improvement of an existing feature label Apr 12, 2024
@itamarst itamarst mentioned this issue Apr 12, 2024
Closed
10 tasks
@itamarst
Copy link
Contributor Author

itamarst commented Apr 12, 2024 •
edited
Loading

https://github.com/pola-rs/polars/compare/main...itamarst:polars:15621-initial-pyo3-0.21-support?expand=1

Mostly there - make test almost passes now, and deprecation warnings have been suppressed for now.

Remaining work:

  • Fix one make test failure
  • Try integration tests and rust tests
  • Figure out what's up with missing markers when I run tests? (recreate venv or something?)
  • See if cargo fmt needs to be run

@itamarst itamarst mentioned this issue Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(python): Initial PyO3 0.21 support itamarst/polars
1 participant
@itamarst