Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): Initial PyO3 0.21 support #15622

Merged
merged 7 commits into from
Apr 13, 2024

Conversation

itamarst
Copy link
Contributor

Fixes #15621

Next step will probably be getting rid of the manual deprecation suppression by switching to the non-deprecated numpy APIs, in the hopes that's somewhat self-contained.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Apr 12, 2024
@itamarst itamarst marked this pull request as ready for review April 12, 2024 21:57
Copy link

codspeed-hq bot commented Apr 12, 2024

CodSpeed Performance Report

Merging #15622 will degrade performances by 10.98%

Comparing itamarst:15621-initial-pyo3-0.21-support (3d78fb2) with main (92902e6)

Summary

❌ 1 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main itamarst:15621-initial-pyo3-0.21-support Change
test_sort_nan_1942 1 ms 1.2 ms -10.98%

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.26%. Comparing base (92902e6) to head (3d78fb2).

Files Patch % Lines
py-polars/src/conversion/mod.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15622   +/-   ##
=======================================
  Coverage   81.25%   81.26%           
=======================================
  Files        1371     1371           
  Lines      175772   175778    +6     
  Branches     2531     2531           
=======================================
+ Hits       142831   142839    +8     
+ Misses      32464    32463    -1     
+ Partials      477      476    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit d42a3b1 into pola-rs:main Apr 13, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial PyO3 0.21 migration, with gil-refs feature enabled
3 participants