Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depr: enforce ignore_nulls default change in 1.0 #16513

Closed
MarcoGorelli opened this issue May 27, 2024 · 1 comment · Fixed by #16754
Closed

depr: enforce ignore_nulls default change in 1.0 #16513

MarcoGorelli opened this issue May 27, 2024 · 1 comment · Fixed by #16754
Assignees
Labels
A-api Area: changes to the public API accepted Ready for implementation python Related to Python Polars
Milestone

Comments

@MarcoGorelli
Copy link
Collaborator

MarcoGorelli commented May 27, 2024

I'm just opening an issue about this so it can be added to the 1.0 milestone without it being forgotten

#14663

the default for ignore_nulls will change from True to False


reasons for enforcing this in 1.0 (as opposed to 2.0):

  • as shown in https://github.com/pola-rs/polars/pull/14663/files, the docs originally documented False to be the default, even though it was True, which suggests an implementation oversight
  • this function matches pandas quite closely, and the default there is ignore_na=False
@MarcoGorelli MarcoGorelli added this to the 1.0.0 milestone May 27, 2024
@stinodego stinodego self-assigned this May 27, 2024
@stinodego stinodego added python Related to Python Polars A-api Area: changes to the public API accepted Ready for implementation labels May 27, 2024
@stinodego
Copy link
Member

This will be closed as part of #13525

But keeping it around as an issue just to be sure is fine I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-api Area: changes to the public API accepted Ready for implementation python Related to Python Polars
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants