Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depr(python): Deprecate default value for ignore_nulls for ewm methods #14663

Merged
merged 4 commits into from
Feb 23, 2024
Merged

depr(python): Deprecate default value for ignore_nulls for ewm methods #14663

merged 4 commits into from
Feb 23, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Feb 23, 2024 •
edited
Loading

Closes #13017

Default will change from True to False.

@github-actions github-actions bot added deprecation Add a deprecation warning to outdated functionality python Related to Python Polars labels Feb 23, 2024
@stinodego stinodego marked this pull request as ready for review February 23, 2024 23:52
@stinodego stinodego merged commit 849953b into main Feb 23, 2024
11 of 12 checks passed
@stinodego stinodego deleted the ewm-depr branch February 23, 2024 23:54
@MarcoGorelli
Copy link
Collaborator

will change

just so we've got this in writing, from what I recall we'd discussed enforcing the deprecation in 1.0 (as opposed to 2.0)

@MarcoGorelli MarcoGorelli mentioned this pull request May 27, 2024
Closed
@stinodego
Copy link
Member Author

just so we've got this in writing, from what I recall we'd discussed enforcing the deprecation in 1.0 (as opposed to 2.0)

Thanks for the reminder. This will be picked up as part of #13525 (it will be a huge PR 😁 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

Assignees
No one assigned
Labels
deprecation Add a deprecation warning to outdated functionality python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ewm_mean default value does not match docstring and pandas API
2 participants
@stinodego @MarcoGorelli