Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off CSE for new streaming engine #18318

Closed
orlp opened this issue Aug 22, 2024 · 0 comments · Fixed by #18330
Closed

Turn off CSE for new streaming engine #18318

orlp opened this issue Aug 22, 2024 · 0 comments · Fixed by #18330
Assignees
Labels
accepted Ready for implementation bug Something isn't working rust Related to Rust Polars

Comments

@orlp
Copy link
Collaborator

orlp commented Aug 22, 2024

CSE can cause with_columns to be generated for common subexpressions with the wrong length, e.g. for

df.select(pl.col.x.explode().filter(pl.col.x.explode() < 5)

In the new streaming engine this is illegal, so the current CSE should be turned off for it. We'll later add CSE at the physical plan level for the new streaming engine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation bug Something isn't working rust Related to Rust Polars
Projects
Archived in project
2 participants