Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Disable common sub-expr elim for new streaming engine #18330

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Aug 23, 2024

Closes #18318.

Sadly does mean we compile the plan twice now when POLARS_AUTO_NEW_STREAMING is set and the query fails the first time.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.43%. Comparing base (c37bad2) to head (7f6ef76).
Report is 3 commits behind head on main.

Files Patch % Lines
crates/polars-lazy/src/frame/mod.rs 94.73% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18330   +/-   ##
=======================================
  Coverage   80.42%   80.43%           
=======================================
  Files        1492     1492           
  Lines      198644   198642    -2     
  Branches     2837     2837           
=======================================
+ Hits       159769   159776    +7     
+ Misses      38349    38340    -9     
  Partials      526      526           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

I am coming up with a superseding PR.

Copy link

codspeed-hq bot commented Aug 23, 2024

CodSpeed Performance Report

Merging #18330 will improve performances by 27.48%

Comparing orlp:polars-new-stream-no-cse (7f6ef76) with main (c37bad2)

Summary

⚡ 1 improvements
✅ 36 untouched benchmarks

Benchmarks breakdown

Benchmark main orlp:polars-new-stream-no-cse Change
test_tpch_q14 2.6 ms 2.1 ms +27.48%

@ritchie46 ritchie46 merged commit 41d3048 into pola-rs:main Aug 23, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn off CSE for new streaming engine
2 participants