chore(python): Address Ruff per file ignores #10258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zundertj
requested review from
ritchie46,
stinodego and
alexander-beedie
as code owners
github-actions
bot
added
internal
stinodego
reviewed
Aug 3, 2023
stinodego
force-pushed
the
ruff_per_file
branch
from
9cc4fde to
7b4261a
Compare
|
Thanks for spotting this improvement! |
|
Sorry, have been busy with other things. Totally fine pushing it in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docstrings for tests is the only (reasonable imo) exception left.
Most exceptions were easy fixes or ignores, the only somewhat useful exception would be to allow statements with no effect for
with pytest.raises( ... )checks (assign to underscore per convention), but I also found a genuine mistake by removing the exception to the rule here.