Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(rust): Bump some dependencies #10396

Merged
merged 9 commits into from
Aug 9, 2023
Merged

build(rust): Bump some dependencies #10396

merged 9 commits into from
Aug 9, 2023

Conversation

stinodego
Copy link
Contributor

@stinodego stinodego commented Aug 9, 2023

Changes:

  • Bump reedline to the latest commit (again) due to issues with the strip-ansi-escapes package
  • Fully qualify dependency versions in the Cargo.toml (e.g. 0.18.0 instead of 0.18). This is equivalent, but now things are more uniform. Unqualify dependency versions (e.g. 0.18 instead of 0.18.0). This is equivalent, but less confusing for those who are not familiar with Cargo and the default caret versioning.
  • Bump memmap2 to the latest version - 0.7
  • Bump sqlparser to the latest version - 0.36
  • Bump bitflags to the latest version - 2
  • Set mimalloc version to its latest version 0.1 instead of * to avoid unexpected breaking changes

@github-actions github-actions bot added build Changes that affect the build system or external dependencies rust Related to Rust Polars labels Aug 9, 2023
@stinodego stinodego marked this pull request as draft August 9, 2023 17:14
@stinodego stinodego marked this pull request as ready for review August 9, 2023 17:36
@ritchie46
Copy link
Member

ritchie46 commented Aug 9, 2023

I actually prefer the less qualified as 0.18.0 is quite misleading as it will take any 0.18.x version.

Not a big issue, but I won't be the first who fell into that trap. So less qualified might save some time in the future.

@stinodego
Copy link
Contributor Author

stinodego commented Aug 9, 2023

I actually prefer the less qualified as 0.18.0 is quite misleading as it will take any 0.18.x version.

Not a big issue, but I won't be the first who fell into that trap. So less qualified might save some time in the future.

Sure, we can go the other way as well. Indeed it's a bit confusing if you don't know that Cargo's default mode is the caret operator. I flip-flopped on this myself while coming up with this PR... I'll adjust the commit!

@stinodego stinodego merged commit 1494033 into main Aug 9, 2023
@stinodego stinodego deleted the bump-deps branch August 9, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants