Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): fix potential OverflowError in testing asserts with huge UInt64 diffs #10437

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Aug 12, 2023

Closes #10436.

Simple fix for asserts that can generate abs(diff) values > max(Int64).

…Uint64 values is itself greater than max Int64
@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Aug 12, 2023
Copy link
Contributor

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant fix 👌

@stinodego stinodego merged commit bdaad51 into pola-rs:main Aug 13, 2023
@alexander-beedie alexander-beedie deleted the fix-uint64-assert branch August 13, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

polars.testing.assert_series_equal() may throw OverflowError if used with UInt
2 participants