fix(python): Fix by argument handling in join_asof #10447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes pola-rs#10427. I noticed that for the right by argument, there was some argument parsing code suggesting it could take expressions, but it will fail. So it is just strings and sequence of strings.
zundertj
requested review from
ritchie46,
stinodego and
alexander-beedie
as code owners
2 tasks
|
Thanks for the fix @zundertj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10427.
I noticed that for the right by argument, there was some argument parsing code suggesting it could take expressions, but it will fail. So it is just strings and sequence of strings.