-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(python): Create .venv
in repo root
#10789
Conversation
I often call Do we really need the user-guide in here though? That's a lot of code and maybe images? I really don't want to bloat this one as it will grow big already. |
In that case, I'd recommend either:
Either of these options seem like much better idea than adding a symlink to the top-level venv.
There is really no good way to keep the user guide up-to-date with the code otherwise. Right now, the guide is instantly outdated anytime we publish a new release. Also, the guide cannot be versioned correctly with the main branch. The more extensive our user guide, the more quickly it will be outdated. So we really have to solve that problem as soon as possible by moving it into the main repo. The amount of code and images is not too bad, actually. Right now, it's a bunch of markdown pages and 3 matplotlib images. And 45 Python code snippets. Also, it will remove clutter from the repo as we finally have a good place to put extensive contributing information and other info. |
Ok.. let's then make a policy to put images in polars-static. I really don't want binary blobs in here as every update is a complete blob. |
We can do that, though we should probably look into using Git LFS or something, as we already have a bunch of binary files in the repo right now. Here's a grep:
I'll put it on my backlog 😄 |
Most if those files are generated IIRC. |
They are not 😞 but let's pick that up separately. Can I go ahead and merge this one? Then I can try to finish the user guide integration. |
Preparation for #10560
Building the user guide requires
mkdocs
, which is a Python dependency. After moving the docs into this repo, we'll also have Python files (code snippets) in thedocs
folder. Because of this, we'll want to run some Python commands from the root of the repo, so it makes sense to move the Python virtual environment to the repo root.This shouldn't impact anyone's workflow. All existing make commands should still work identically.
Changes
.venv
requirements
clean
help
.venv
/requirements
commands and use the right venv path..venv
referencesdprint
plugin versions