tests(python): account for version-based issue with pyarrow datetime units in tests #11052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46 and
stinodego
as code owners
|
One down, a bunch of |
|
Why not just pin deltalake to 0.10.1 for now? We want to run our tests with the latest pyarrow version. I'd say that's way more important than having the latest patch version of deltalake. |
Yup, I'm thinking the same now - just found the relevant issue on their repo: delta-io/delta-rs#1602. |
alexander-beedie
force-pushed
the
fix-unit-tests
branch
from
3e30bbf
to
14ac2ca
Compare
ritchie46
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest
deltalakepinnedpyarrowat< 13, causing some unit test failures on package update (as we had previously updated the test to handle the changes in 13 and got unexpectedly reverted back to 12 by their pin).