feat: Implement is_between in Rust
#11945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
reswqa
reviewed
Oct 23, 2023
reswqa
reviewed
Oct 23, 2023
petrosbar
requested review from
ritchie46,
stinodego,
alexander-beedie and
orlp
as code owners
orlp
requested changes
Oct 23, 2023
petrosbar
force-pushed
the
feature/is_between_rust
branch
from
2824c0a
to
3e6ba17
Compare
petrosbar
force-pushed
the
feature/is_between_rust
branch
from
3e6ba17
to
daef54a
Compare
orlp
approved these changes
Oct 25, 2023
petrosbar
force-pushed
the
feature/is_between_rust
branch
2 times, most recently
from
1dc9598
to
2f34637
Compare
|
@ritchie46 @stinodego, would like to kindly ask to get some attention to this PR, so that I can address any comments or suggestions, if the PR is considered of any value, or else close it so that it doesn't "pollute" the repo. |
stinodego
force-pushed
the
feature/is_between_rust
branch
from
2f34637
to
a6d152d
Compare
stinodego
approved these changes
Jan 11, 2024
|
|
||
| #[derive(Copy, Clone, Debug, Hash, Eq, PartialEq, Default)] | ||
| #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] | ||
| pub enum ClosedInterval { |
There was a problem hiding this comment.
Too bad we can't reuse the existing ClosedWindow enum as it's in the polars-time crate which is not available here. But I guess it's fine this way.
stinodego
changed the title
is_between on the Rust side
stinodego
changed the title
is_between on the Rust sideis_between in Rust
r-brink
pushed a commit
to r-brink/polars
that referenced
this pull request
Jan 24, 2024
Co-authored-by: Stijn de Gooijer <stijndegooijer@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11285