chore(python): Replace black by ruff format
#11996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
stinodego
commented
Oct 24, 2023
stinodego
commented
Oct 24, 2023
stinodego
force-pushed
the
ruff-formatter
branch
from
031f60b
to
c376daf
Compare
stinodego
commented
Oct 24, 2023
stinodego
requested review from
ritchie46,
c-peters and
alexander-beedie
as code owners
|
Alright, shall we wait a little bit to get all issues ironed out? |
I don't think that's necessary. They are very minor issues and the workarounds are fine. They shouldn't trip anyone up. And the formatter has improved things in a lot of other places! I'd say let's merge this. |
|
I'm for it. |
|
Happy days... I switched a chunk of the work codebase onto (Only hit one or two -literally- oddities; easily worked around). |
stinodego
changed the title
black by ruff formatblack by ruff format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11993
Overal, some nice formatting improvements, and of course, much faster formatting!