feat(rust, python,cli): add support for AND in SQL join-clause context #13242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaarrti
requested review from
ritchie46,
orlp and
universalmind303
as code owners
|
@alexander-beedie can you take a look at this one? |
|
Will do; slipped my radar over Xmas & the New Year 👌 |
alexander-beedie
force-pushed
the
#11290-compound-join-sql
branch
from
cce96b9
to
7f8ad38
Compare
|
(Just doing a rebase; will start looking) |
alexander-beedie
force-pushed
the
#11290-compound-join-sql
branch
2 times, most recently
from
2d81c71
to
9e17ebb
Compare
alexander-beedie
force-pushed
the
#11290-compound-join-sql
branch
from
9e17ebb
to
fc7bebe
Compare
aaarrti
requested review from
alexander-beedie and
MarcoGorelli
as code owners
alexander-beedie
force-pushed
the
#11290-compound-join-sql
branch
from
7792cdc
to
798f6b8
Compare
|
Ok, I slightly streamlined some vec accumulation and added a set of additional tests (on the Python side) to help further validate. All pass, so seems to be working well - didn't change any of the logic, everything worked "as-is". Thanks for the PR @aaarrti :) @ritchie46: looks good to go. |
alexander-beedie
approved these changes
Jan 4, 2024
ritchie46
approved these changes
Jan 5, 2024
alexander-beedie
changed the title
github-actions
bot
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the issue described here #11290
Hi @alexander-beedie, tbh I am not very happy with how I managed to organize it. I also had a hard time thinking of the test cases, so I'd like to hear your recommendations!