Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depr(python,rust!): Rename with_row_count to with_row_index #13494

Merged
merged 7 commits into from
Jan 8, 2024
Merged

depr(python,rust!): Rename with_row_count to with_row_index #13494

merged 7 commits into from
Jan 8, 2024

Commits on Jan 8, 2024

  1. Update docs

    @stinodego
    stinodego committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    93f01ed View commit details
    Browse the repository at this point in the history

  2. Rename on Python side

    @stinodego
    stinodego committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    7cd4604 View commit details
    Browse the repository at this point in the history

  3. Update tests

    @stinodego
    stinodego committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    233874c View commit details
    Browse the repository at this point in the history

  4. Rename on Rust side

    @stinodego
    stinodego committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    7aa61f8 View commit details
    Browse the repository at this point in the history

  5. Rename to with_row_index

    @stinodego
    stinodego committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    16b7492 View commit details
    Browse the repository at this point in the history

  6. Change default name to "index"

    @stinodego
    stinodego committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    c83565e View commit details
    Browse the repository at this point in the history

  7. Improve docstrings and handle bad offsets

    @stinodego
    stinodego committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    f4383c2 View commit details
    Browse the repository at this point in the history