Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Impl contains for ArrayNameSpace #13638

Merged
merged 1 commit into from
Jan 12, 2024
Merged

feat: Impl contains for ArrayNameSpace #13638

merged 1 commit into from
Jan 12, 2024

Conversation

reswqa
Copy link
Collaborator

@reswqa reswqa commented Jan 11, 2024 •
edited
Loading

Since we have already supports is_in for array. It's not hard to implement contains then.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jan 11, 2024
@reswqa reswqa marked this pull request as ready for review January 11, 2024 14:03
@ritchie46 ritchie46 merged commit f59f9af into pola-rs:main Jan 12, 2024
28 checks passed
@reswqa reswqa deleted the arr_contains branch January 12, 2024 16:49
r-brink pushed a commit to r-brink/polars that referenced this pull request Jan 24, 2024
@reswqa @r-brink
feat: Impl contains for ArrayNameSpace (pola-rs#13638)
7982f07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@stinodego stinodego Awaiting requested review from stinodego

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reswqa @ritchie46