Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Impl count_matches for array namespace #13675

Merged
merged 3 commits into from
Jan 17, 2024
Merged

feat: Impl count_matches for array namespace #13675

merged 3 commits into from
Jan 17, 2024

Conversation

reswqa
Copy link
Collaborator

@reswqa reswqa commented Jan 12, 2024 •
edited
Loading

Maybe I can optimize arr.sum of boolean type via count_boolean_bits in the next PR.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jan 12, 2024
@reswqa reswqa marked this pull request as ready for review January 13, 2024 14:32
@reswqa
Copy link
Collaborator Author

reswqa commented Jan 17, 2024 •
edited
Loading

@ritchie46 Would you mind reviewing this one? There are a few subsequent PRs that rely on it.

I wanted to improve the Array type support as much as possible before we release 1.0(I guess it won't be long).

@orlp
Copy link
Collaborator

orlp commented Jan 17, 2024 •
edited
Loading

I reviewed the Rust side and looks good to me, @stinodego could you take a look at the Python side? If that's good then this is ready to merge.

@stinodego stinodego merged commit 5fbce48 into pola-rs:main Jan 17, 2024
23 checks passed
r-brink pushed a commit to r-brink/polars that referenced this pull request Jan 22, 2024
@reswqa @stinodego @r-brink
feat: Impl count_matches for array namespace (pola-rs#13675)
12b8cc4 
Co-authored-by: Stijn de Gooijer <stijndegooijer@gmail.com>
r-brink pushed a commit to r-brink/polars that referenced this pull request Jan 24, 2024
@reswqa @stinodego @r-brink
feat: Impl count_matches for array namespace (pola-rs#13675)
ece6b00 
Co-authored-by: Stijn de Gooijer <stijndegooijer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reswqa @orlp @stinodego