-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust, python, cli): Add ignore_nulls
for list.join
#13701
Conversation
ignore_nulls
for list.join
ignore_nulls
for list.join
d5f1265
to
8549df6
Compare
619de08
to
4fae592
Compare
4fae592
to
7059210
Compare
Rebased on master to resolve the conflict. And @stinodego fancy taking a look at this? The changes are relatively minor, but breaking compatibility. |
I think we must wait until a breaking release then. :/ |
Make sense, we should merge this when |
Just to be clear, the existing behavior is: import polars as pl
s = pl.Series([["a", None, "b"], ["c", None]])
result = s.list.join("")
print(result)
That looks broken to me and I can't imagine anyone relies on this behavior. In my opinion, this PR can be merged as a fix. |
@reswqa: looks like the latest |
Ohh, It occurs to me that our introduction of the |
7059210
to
198fa2d
Compare
Resolved merge conflicts / rebased 👍 |
@stinodego: Yup; it also enables a definite fix on the SQL side (for slightly different reasons - |
ignore_nulls
for list.join
ignore_nulls
for list.join
Co-authored-by: alexander-beedie <alexander.m.beedie@icloud.com>
198fa2d
to
3a361f3
Compare
And one last rebase (following #13877). |
…13701) Co-authored-by: alexander-beedie <alexander.m.beedie@icloud.com>
This should be a breaking change as null value is no longer be treated as a string
null
.