Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depr(python,rust!): Rename pl.count() to pl.len() #13719

Merged
merged 4 commits into from
Jan 16, 2024
Merged

depr(python,rust!): Rename pl.count() to pl.len() #13719

merged 4 commits into from
Jan 16, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jan 14, 2024 •
edited
Loading

Closes #13673

Changes

  • Rename pl.count() to pl.len()
  • Rename group_by(...).count() to group_by(...).len()
  • Rename pivot aggregate function "count" to "len"
  • Deprecate pl.cum_count() (with no args). The name makes no sense anymore and it was just an alias for int_range anyway.

@github-actions github-actions bot added breaking rust Change that breaks backwards compatibility for the Rust crate deprecation Add a deprecation warning to outdated functionality python Related to Python Polars rust Related to Rust Polars labels Jan 14, 2024
@stinodego stinodego force-pushed the count-to-len branch 2 times, most recently from 8b1b900 to 6924a99 Compare January 14, 2024 14:55
@stinodego stinodego marked this pull request as ready for review January 14, 2024 15:19
@ritchie46 ritchie46 merged commit 44a469c into main Jan 16, 2024
26 checks passed
@ritchie46 ritchie46 deleted the count-to-len branch January 16, 2024 15:35
alexander-beedie pushed a commit to alexander-beedie/polars that referenced this pull request Jan 16, 2024
@stinodego @alexander-beedie
depr(python,rust!): Rename pl.count() to pl.len() (pola-rs#13719)
4a44f51
r-brink pushed a commit to r-brink/polars that referenced this pull request Jan 24, 2024
@stinodego @r-brink
depr(python,rust!): Rename pl.count() to pl.len() (pola-rs#13719)
3fb7ab7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@universalmind303 universalmind303 Awaiting requested review from universalmind303

Assignees
No one assigned
Labels
breaking rust Change that breaks backwards compatibility for the Rust crate deprecation Add a deprecation warning to outdated functionality python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename argument-less pl.count() to pl.len()
2 participants
@stinodego @ritchie46