feat: Expressify str.slice
#13747
feat: Expressify str.slice
#13747
Conversation
github-actions
bot
added
enhancement
|
@alexander-beedie You might be interested in this :) This will work well with |
reswqa
force-pushed
the
str_slice_expr
branch
from
c866553
to
ed4cd28
Compare
Powerful combination! 😎 |
| @@ -905,11 +905,11 @@ impl SQLFunctionVisitor<'_> { | |||
| Reverse => self.visit_unary(|e| e.str().reverse()), | |||
| Right => self.try_visit_binary(|e, length| { | |||
| Ok(e.str().slice( match length { | |||
| Expr::Literal(LiteralValue::Int64(n)) => -n, | |||
| Expr::Literal(LiteralValue::Int64(n)) => lit(-n), | |||
There was a problem hiding this comment.
@alexander-beedie I've mostly left the SQL part as it is, so feel free to push a new commit or open a new PR if you want to improve it to work better with expressions.
There was a problem hiding this comment.
Will do; thx! :))
| }) | ||
| }, | ||
| (len_a, 1, len_c) if len_a == len_c => { | ||
| fn infer<F: for<'a> FnMut(Option<&'a str>, Option<u64>) -> Option<&'a str>>(f: F) -> F where |
There was a problem hiding this comment.
The compiler is a bit annoying, so we have to introduce this infer function to keep it happy.
Co-authored-by: cmdlineluser <99486669+cmdlineluser@users.noreply.github.com>
reswqa
force-pushed
the
str_slice_expr
branch
from
ed4cd28
to
c617570
Compare
reswqa
requested review from
ritchie46,
stinodego,
c-peters,
MarcoGorelli,
orlp and
universalmind303
as code owners
There was a problem hiding this comment.
Nice one. Thanks @mcrumiller and @reswqa for the unified effort. 😄
|
@ritchie46 I think you meant to thank @cmdlineluser, I didn't contribute to this one! |
|
IDK what precisely is going on there, but at this point it looks like its all my fault, sorry if I alarmed someone. Unless I cleared that up and found a minimal example that shows a difference between releases, I'll have to retract this. |
Co-authored-by: cmdlineluser <99486669+cmdlineluser@users.noreply.github.com>
This comes from @cmdlineluser's nice work. It's hard to make any changes in the original commit due to too many code conflicts, but I'm listing him as a co-author to keep authorship :)