Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rust!): Rename drop_columns to drop #13754

Merged
merged 1 commit into from
Jan 17, 2024
Merged

feat(rust!): Rename drop_columns to drop #13754

merged 1 commit into from
Jan 17, 2024

Conversation

stinodego
Copy link
Member

Ref #13745

To align with the public API on the Python side.

@github-actions github-actions bot added breaking rust Change that breaks backwards compatibility for the Rust crate internal An internal refactor or improvement rust Related to Rust Polars labels Jan 15, 2024
@stinodego stinodego changed the title refactor(rust!): Rename drop_columns to drop feat(rust!): Rename drop_columns to drop Jan 15, 2024
@stinodego stinodego removed the internal An internal refactor or improvement label Jan 15, 2024
@github-actions github-actions bot added the enhancement New feature or an improvement of an existing feature label Jan 15, 2024
@stinodego stinodego marked this pull request as ready for review January 15, 2024 21:21
@ritchie46 ritchie46 merged commit 45e4ce8 into main Jan 17, 2024
24 checks passed
@ritchie46 ritchie46 deleted the drop branch January 17, 2024 06:45
@c-peters c-peters added the accepted Ready for implementation label Jan 23, 2024
r-brink pushed a commit to r-brink/polars that referenced this pull request Jan 24, 2024
@stinodego @r-brink
feat(rust!): Rename drop_columns to drop (pola-rs#13754)
1fe7954
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@alexander-beedie alexander-beedie alexander-beedie approved these changes

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@universalmind303 universalmind303 Awaiting requested review from universalmind303

Assignees

@stinodego stinodego

Labels
accepted Ready for implementation breaking rust Change that breaks backwards compatibility for the Rust crate enhancement New feature or an improvement of an existing feature rust Related to Rust Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stinodego @alexander-beedie @ritchie46 @c-peters