Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): Fix incorrect "coming from pandas" syntax #13767

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

MarcoGorelli
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars labels Jan 16, 2024
Comment on lines -296 to +288
pl.col("c").reverse().over("c").flatten().alias("reverse_type")
pl.col("type").reverse().over("c").alias("reverse_type")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure this was a typo:

  • the original expression was aliased to "reverse_type", but never used type
  • reversing 'c' over 'c' is a no-op...

I've also removed .flatten as it doesn't do anything here

@MarcoGorelli MarcoGorelli marked this pull request as ready for review January 16, 2024 15:07
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid changes, thanks!

@stinodego stinodego changed the title docs: fixup incorrect "coming from pandas" syntax docs(python): Fix incorrect "coming from pandas" syntax Jan 16, 2024
@stinodego stinodego merged commit 55284d8 into pola-rs:main Jan 16, 2024
5 checks passed
alexander-beedie pushed a commit to alexander-beedie/polars that referenced this pull request Jan 16, 2024
r-brink pushed a commit to r-brink/polars that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants