feat(python): allow ftp URLs, improve URL check
#13781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
stinodego,
c-peters and
MarcoGorelli
as code owners
github-actions
bot
added
enhancement
stinodego
approved these changes
Jan 18, 2024
| @@ -222,7 +222,11 @@ def _check_empty( | |||
| return b | |||
|
|
|||
|
|
|||
| def _process_http_file(path: str, encoding: str | None = None) -> BytesIO: | |||
| def _looks_like_url(path: str) -> bool: | |||
| return re.match("^(ht|f)tps?://", path, re.IGNORECASE) is not None | |||
There was a problem hiding this comment.
Today I learned about the FTPS protocol 😄
r-brink
pushed a commit
to r-brink/polars
that referenced
this pull request
Jan 22, 2024
r-brink
pushed a commit
to r-brink/polars
that referenced
this pull request
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a very basic check against string file paths to see if they looked like they might be a URL (just "starts with
http"). This can lead to (somewhat unlikely) false positives against files in the local working dir, fail on upper/mixed case URL prefixes, and excludes theftpprotocol, which the underlyingurlopenmethod does actually handle.Made the check more robust, and added some related unit tests.
Validated by loading CSV data off an
ftpserver; worked fine👌