Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust,python): Add nulls_last for Series.sort #13794

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

mcrumiller
Copy link
Contributor

@mcrumiller mcrumiller commented Jan 17, 2024

Closes #13788

Other half of the work for #13788.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jan 17, 2024
@mcrumiller mcrumiller changed the title feat(rust,python): Add nulls_last parameter for Series.sort feat(rust,python): Add nulls_last for Series.sort Jan 17, 2024
@mcrumiller
Copy link
Contributor Author

@ritchie46 this one is pretty simple, I think good to go.

Copy link
Collaborator

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@reswqa reswqa merged commit 88ade63 into pola-rs:main Jan 18, 2024
26 checks passed
r-brink pushed a commit to r-brink/polars that referenced this pull request Jan 24, 2024
@mcrumiller mcrumiller deleted the series-sort-nulls-last branch February 26, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nulls_last parameter to all sort methods
3 participants