-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): Add typing to hvplot plot namespace #13813
feat(python): Add typing to hvplot plot namespace #13813
Conversation
hey - hvplot doesn't have a |
ah, nice! should be fine then, do you want to add it for |
Done! Thanks, I wasn't aware it existed there too! Thank you so much for the plotting functionality! It really adds that extra bit of elegance to the whole package! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @thomasaarholt !
@hoxbro sorry for the ping, just wanted to check if hvplot.plotting.core.hvPlotTabularPolars
can be considered public, and if not, if there's anything else which should be used?
Joining in the fun 😅 Moved the |
It can be considered public. And you are always welcome to ping me 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks all!
Co-authored-by: alexander-beedie <alexander.m.beedie@icloud.com>
Tagging @MarcoGorelli who added the super nice plotting functionality.
I noticed that I didn't get type hinting on the
df.plot
namespace, so decided to add it here. Were there any particular reasons you didn't do so?Note that since we
from __future__ import annotations
, the return type won't raise a runtime this (without strings) despite hvplot possibly not being installed.