feat: support cast decimal to utf8 #13829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flisky
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
|
Your timing is a bit unlucky. We just swapped the internal string type in polars. |
flisky
force-pushed
the
dec2str
branch
2 times, most recently
from
848c8ba
to
701b8c0
Compare
|
@flisky can you rewrite to the new |
|
Okay, I'll try tomorrow. |
ritchie46
changed the title
github-actions
bot
added
enhancement
r-brink
pushed a commit
to r-brink/polars
that referenced
this pull request
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pushed down
format_decimalfrom polars-core into polars-arrow.